Skip to content

min_const_generics: allow ty param in repeat expr #78224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2020
Merged

min_const_generics: allow ty param in repeat expr #78224

merged 2 commits into from
Oct 29, 2020

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Oct 22, 2020 •
edited
Loading

implements https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/repeat.20expressions

Even with min_const_generics active, now keeps resulting in future compat warnings instead of hard errors.
Const parameters, for example [0; N + 1], still result in hard errors during resolve.

#![allow(dead_code)]

fn foo<T>() {
    [0; std::mem::size_of::<*mut T>()];
}

struct Foo<T>(T);

impl<T> Foo<T> {
    const ASSOC: usize = 4;

    fn test() {
        [0; Self::ASSOC];
    }
}

r? @varkor cc @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2020
@varkor varkor added A-const-generics Area: const generics (parameters and arguments) F-const_generics `#![feature(const_generics)]` labels Oct 23, 2020
@varkor
Copy link
Contributor

varkor commented Oct 28, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 28, 2020

📌 Commit 83ecbb4 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2020
@jonas-schievink jonas-schievink mentioned this pull request Oct 28, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Oct 29, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2020
@bors
Auto merge of rust-lang#78512 - JohnTitor:rollup-a7qwjah, r=JohnTitor
49720d2 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#77213 (rustdoc options to set default theme (and other settings))
 - rust-lang#78224 (min_const_generics: allow ty param in repeat expr)
 - rust-lang#78428 (MinConstGenerics UI test for invalid values for bool & char)
 - rust-lang#78460 (Adjust turbofish help message for const generics)
 - rust-lang#78470 (Clean up intra-doc links in `std::path`)
 - rust-lang#78475 (fix a comment in validity check)
 - rust-lang#78478 (Add const generics tests for supertraits + dyn traits.)
 - rust-lang#78487 (Fix typo "compiltest")
 - rust-lang#78491 (Inline NonZeroN::from(n))
 - rust-lang#78492 (Update books)
 - rust-lang#78494 (Fix typos)

Failed merges:

r? `@ghost`
@bors bors merged commit 270d2e0 into rust-lang:master Oct 29, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 29, 2020
@lcnr lcnr deleted the repeat-expr branch October 29, 2020 08:27
@lcnr lcnr mentioned this pull request Nov 17, 2020
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
A-const-generics Area: const generics (parameters and arguments) F-const_generics `#![feature(const_generics)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lcnr @varkor @bors @rust-highfive @rustbot